Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Unify cache location configurability #22079

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

kubijo
Copy link
Contributor

@kubijo kubijo commented Apr 13, 2023

Closes #22044

What I did

Use find-cache-dir in places where the cache location was still constructed somewhat manually.

How to test

Providing a custom cache directory location in a CACHE_DIR environment variable should result in it being used by storybook instead of node_modules/.cache/*

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kubijo
Copy link
Contributor Author

kubijo commented Apr 13, 2023

Continuation from #22047 since I've screwed-up the branch name before

@shilman shilman changed the title Unify cache location configurability #22044 Core: Unify cache location configurability Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Unify the cache locations configurability by using find-cache-dir everywhere
3 participants